Re: [Openvpn-devel] [PATCH] Fix socks_proxy_port pointing to invalid data

2017-07-07 Thread David Sommerseth
On 07/07/17 23:11, Christian Hesse wrote: > Thomas Veerman via Openvpn-devel on > Fri, 2017/07/07 21:59: >> else if (streq(p[1], "SOCKS")) >> { >> ce->socks_proxy_server = string_alloc(p[2], gc); >> -ce->socks_proxy_port = p[3]; >> +ce->socks_

Re: [Openvpn-devel] [PATCH] Fix socks_proxy_port pointing to invalid data

2017-07-07 Thread Christian Hesse
Thomas Veerman via Openvpn-devel on Fri, 2017/07/07 21:59: > else if (streq(p[1], "SOCKS")) > { > ce->socks_proxy_server = string_alloc(p[2], gc); > -ce->socks_proxy_port = p[3]; > +ce->socks_proxy_port = string_alloc(p[3], gc); >

Re: [Openvpn-devel] [PATCH] Fix socks_proxy_port pointing to invalid data

2017-07-07 Thread Arne Schwabe
Am 07.07.17 um 21:59 schrieb Thomas Veerman via Openvpn-devel: > When setting the SOCKS proxy through the management interface, the > socks_proxy_port pointer would be set to a value that's no longer valid > by the time it's used by do_preresolve_host. > > Signed-off-by: Thomas Veerman > --- > s