Re: [Openvpn-devel] [PATCH] Fix file checks when --chroot is being used

2013-12-11 Thread Steffan Karger
Sorry for the late response, but better late then never. So, ACK to this patch! -Steffan On 25-11-13 13:32, David Sommerseth wrote: > From: David Sommerseth > > Commit 0f2bc0dd92f43c9 started to introduce some file sanity > checking before OpenVPN started to avoid harder to explain issues > due

Re: [Openvpn-devel] [PATCH] Fix file checks when --chroot is being used

2013-11-26 Thread Gert Doering
Hi, On Tue, Nov 26, 2013 at 12:15:09PM +0100, David Sommerseth wrote: > and Gert will apply whatever gets an ACK I presume :) ACK! :) (On that statement, not on the patch, all my brains are focused on the dual-stack patch set) gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH] Fix file checks when --chroot is being used

2013-11-26 Thread David Sommerseth
On 23. nov. 2013 10:53, Steffan Karger wrote: > Hi David, > > This solution looks good. I did not test, but I do have one minor > comment after glancing at the code: > > @@ -2662,7 +2700,14 @@ check_cmd_access(const char *command, const > char *opt) * only requires X_OK to function on Unix - a scen

Re: [Openvpn-devel] [PATCH] Fix file checks when --chroot is being used

2013-11-23 Thread Steffan Karger
Hi David, This solution looks good. I did not test, but I do have one minor comment after glancing at the code: @@ -2662,7 +2700,14 @@ check_cmd_access(const char *command, const char > *opt) > * only requires X_OK to function on Unix - a scenario not unlikely to > * be seen on suid