Re: [Openvpn-devel] [PATCH] Fix broken ./configure on systems without openssl.pc

2017-04-15 Thread Gert Doering
Hi, On Sat, Apr 15, 2017 at 11:42:30AM +0200, David Sommerseth wrote: > So reviewing this now, this 12 bit shift may actually fail on big endian > machines. It would probably be better to do a full 16 bit shift. > > But if we don't want to reduce the match set to only version numbers, > I'm fine

Re: [Openvpn-devel] [PATCH] Fix broken ./configure on systems without openssl.pc

2017-04-15 Thread David Sommerseth
On 15/04/17 11:16, Gert Doering wrote: > Hi, > > On Thu, Apr 13, 2017 at 07:26:09PM +0200, David Sommerseth wrote: >> +/* Strip out some of the version information we don't care about */ >> +#define OSSLVER OPENSSL_VERSION_NUMBER >> 12 >> +#if OSSLVER < 0x10001 >> +#error OpneSSL too old >> +#endi

Re: [Openvpn-devel] [PATCH] Fix broken ./configure on systems without openssl.pc

2017-04-15 Thread Gert Doering
Hi, On Thu, Apr 13, 2017 at 07:26:09PM +0200, David Sommerseth wrote: > +/* Strip out some of the version information we don't care about */ > +#define OSSLVER OPENSSL_VERSION_NUMBER >> 12 > +#if OSSLVER < 0x10001 > +#error OpneSSL too old > +#endif While this works (except for the typo) - why no