Re: [Openvpn-devel] [PATCH] Enable dhcp on tap adapter using interactive service

2018-10-01 Thread Selva Nair
Hi, Thanks for the review and comments. A quick reply below, will send a v2 later. On Mon, Oct 1, 2018 at 7:11 AM Lev Stipakov wrote: > Hi, > > Thanks, I tested on Windows 10 with Visual Studio build and works as > expected. > > A few nitpicks: > > +if (!WriteFile(pipe, &dhcp, sizeof(dhcp),

Re: [Openvpn-devel] [PATCH] Enable dhcp on tap adapter using interactive service

2018-10-01 Thread Lev Stipakov
Hi, Thanks, I tested on Windows 10 with Visual Studio build and works as expected. A few nitpicks: +if (!WriteFile(pipe, &dhcp, sizeof(dhcp), &len, NULL) > +|| !ReadFile(pipe, &ack, sizeof(ack), &len, NULL)) > +{ > +msg(M_WARN, "TUN: could not talk to service: %s [%lu]",