Re: [Openvpn-devel] [PATCH] Don't "undo" ifconfig when given --ifconfig-noexec

2021-11-17 Thread Maximilian Fillinger
> ... so why is "did_ifconfig_setup" true, if ifconfig wasn't done? > > Or, phrased differently, what is did_ifconfig_setup used for, across the > code, and can we just "not set it to true" if ifconfig-noexec is in > effect? Or does it have nasty side effects? tt->did_ifconfig_setup is set in

Re: [Openvpn-devel] [PATCH] Don't "undo" ifconfig when given --ifconfig-noexec

2021-11-17 Thread Gert Doering
Hi, On Wed, Nov 17, 2021 at 06:54:24PM +0100, Max Fillinger wrote: > When running with --ifconfig-noexec on Linux, OpenVPN may still delete > the ip address from the tun interface on exit, because it tries to undo > the ifconfig that did not actually happen. > > This commit reintroduces the did_i