Re: [Openvpn-devel] [PATCH] Add nl_for_brace=add to uncrustify.conf

2016-12-23 Thread Selva Nair
On Fri, Dec 23, 2016 at 4:59 PM, Steffan Karger wrote: > On 23-12-16 22:44, Steffan Karger wrote: > > On 23-12-16 22:23, Selva Nair wrote: > >> > >> On Fri, Dec 23, 2016 at 3:26 PM, Steffan Karger >> > wrote: > >> > >> diff --git a/dev-tools/uncrustify.conf b/dev-to

Re: [Openvpn-devel] [PATCH] Add nl_for_brace=add to uncrustify.conf

2016-12-23 Thread Steffan Karger
On 23-12-16 22:44, Steffan Karger wrote: > On 23-12-16 22:23, Selva Nair wrote: >> >> On Fri, Dec 23, 2016 at 3:26 PM, Steffan Karger > > wrote: >> >> diff --git a/dev-tools/uncrustify.conf b/dev-tools/uncrustify.conf >> index 95e0b2a..3745ed0 100644 >> --- a/

Re: [Openvpn-devel] [PATCH] Add nl_for_brace=add to uncrustify.conf

2016-12-23 Thread Steffan Karger
On 23-12-16 22:23, Selva Nair wrote: > > On Fri, Dec 23, 2016 at 3:26 PM, Steffan Karger > wrote: > > diff --git a/dev-tools/uncrustify.conf b/dev-tools/uncrustify.conf > index 95e0b2a..3745ed0 100644 > --- a/dev-tools/uncrustify.conf > +++ b/dev-tools

Re: [Openvpn-devel] [PATCH] Add nl_for_brace=add to uncrustify.conf

2016-12-23 Thread Gert Doering
Hi, On Fri, Dec 23, 2016 at 04:23:48PM -0500, Selva Nair wrote: > nl_after_semicolon > (I know no one here writes x=1; y=2; z= 3; on the same line, Well... looking at route.c, seems I've been guilty of a few such cases... But then, I'm not sure I consider this necessarily a "MUST CHANGE!" bad st

Re: [Openvpn-devel] [PATCH] Add nl_for_brace=add to uncrustify.conf

2016-12-23 Thread Selva Nair
On Fri, Dec 23, 2016 at 3:26 PM, Steffan Karger wrote: > diff --git a/dev-tools/uncrustify.conf b/dev-tools/uncrustify.conf > index 95e0b2a..3745ed0 100644 > --- a/dev-tools/uncrustify.conf > +++ b/dev-tools/uncrustify.conf > @@ -9,6 +9,7 @@ nl_brace_else=add > nl_elseif_brace=add > nl_else_bra