Re: [Openvpn-devel] potential segfault on strlen(NULL)

2016-06-07 Thread Илья Шипицин
2016-06-07 19:11 GMT+05:00 Gert Doering : > Hi, > > On Tue, Jun 07, 2016 at 06:04:54PM +0500, ?? wrote: > > as I see, there's call to format_hex_ex with separator=NULL here: > > Interesting find. > > This code is funny - format_hex_ex() is called from various places with > sep

Re: [Openvpn-devel] potential segfault on strlen(NULL)

2016-06-07 Thread Gert Doering
Hi, On Tue, Jun 07, 2016 at 06:04:54PM +0500, ?? wrote: > as I see, there's call to format_hex_ex with separator=NULL here: Interesting find. This code is funny - format_hex_ex() is called from various places with separator=NULL, and has been that way since at least 2005.

[Openvpn-devel] potential segfault on strlen(NULL)

2016-06-07 Thread Илья Шипицин
Hello, I'm investigating some cppcheck findings, for example: [src/openvpn/buffer.c:442] -> [src/openvpn/buffer.c:447]: (warning) Either the condition 'if(separator&&i&&!(i%(space_break_flags&255)))' is redundant or there is possible null pointer dereference: separator. [src/openvpn/buffer.c:443]