Re: [Openvpn-devel] patch for bug #93: up-restart env vars

2015-05-22 Thread Gert Doering
Hi, On Fri, May 22, 2015 at 01:39:18PM +0200, Jan Just Keijser wrote: > > - add a patch to openvpn.8 that explains the differences in --up-restart > > (so people will know that the lack of route env vars is not a bug) > > agreed, but do we patch openvpn.8 before or after the documentation > sp

Re: [Openvpn-devel] patch for bug #93: up-restart env vars

2015-05-22 Thread Jan Just Keijser
Gert Doering wrote: Hi, On Fri, May 22, 2015 at 12:01:24AM +0200, Jan Just Keijser wrote: I'm not sure what the best path forward is, TBH... --up-restart *is* different from --up in several ways: - runs as the user+group that is specified in the config file - the 'tun' device is per

Re: [Openvpn-devel] patch for bug #93: up-restart env vars

2015-05-22 Thread Gert Doering
Hi, On Fri, May 22, 2015 at 12:01:24AM +0200, Jan Just Keijser wrote: > >I'm not sure what the best path forward is, TBH... > > --up-restart *is* different from --up in several ways: > > - runs as the user+group that is specified in the config file > - the 'tun' device is persistent so it's not

Re: [Openvpn-devel] patch for bug #93: up-restart env vars

2015-05-21 Thread Jan Just Keijser
Hi, On 21/05/15 20:31, Gert Doering wrote: On Thu, May 21, 2015 at 08:20:39PM +0200, Jan Just Keijser wrote: On 21/05/15 20:14, Gert Doering wrote: On Wed, May 20, 2015 at 04:33:20AM +0200, Jan Just Keijser wrote: here's my patch for bug #93: missing ifconfig_* env vars after up-restart. Test

Re: [Openvpn-devel] patch for bug #93: up-restart env vars

2015-05-21 Thread Gert Doering
Hi, On Thu, May 21, 2015 at 08:20:39PM +0200, Jan Just Keijser wrote: > On 21/05/15 20:14, Gert Doering wrote: > >On Wed, May 20, 2015 at 04:33:20AM +0200, Jan Just Keijser wrote: > >>here's my patch for bug #93: missing ifconfig_* env vars after > >>up-restart. Tested with both IPv4, IPv6, topolo

Re: [Openvpn-devel] patch for bug #93: up-restart env vars

2015-05-21 Thread Jan Just Keijser
Hi Gert, On 21/05/15 20:14, Gert Doering wrote: Hi, On Wed, May 20, 2015 at 04:33:20AM +0200, Jan Just Keijser wrote: here's my patch for bug #93: missing ifconfig_* env vars after up-restart. Tested with both IPv4, IPv6, topology subnet and topology net30 Reading through #93, I'm wondering -

Re: [Openvpn-devel] patch for bug #93: up-restart env vars

2015-05-21 Thread Gert Doering
Hi, On Wed, May 20, 2015 at 04:33:20AM +0200, Jan Just Keijser wrote: > here's my patch for bug #93: missing ifconfig_* env vars after > up-restart. Tested with both IPv4, IPv6, topology subnet and topology net30 Reading through #93, I'm wondering - what about the other environment variables men

[Openvpn-devel] patch for bug #93: up-restart env vars

2015-05-20 Thread Jan Just Keijser
hi all, here's my patch for bug #93: missing ifconfig_* env vars after up-restart. Tested with both IPv4, IPv6, topology subnet and topology net30 cheers, JJK diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 42cb3e2..a4b5e05 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.