Re: [Openvpn-devel] automatically close PR

2016-05-17 Thread Samuli Seppänen
I have a strong preference for using GitHub at least for vetting out most bugs. We're not going to use GitHub for the actual patch merging process - that is "mailing list, public ACK, merge, push to github + sourceforge", at least today. For review, PRs should be doable. Speaking of reviewi

Re: [Openvpn-devel] automatically close PR

2016-05-17 Thread Samuli Seppänen
I have a strong preference for using GitHub at least for vetting out most bugs. We're not going to use GitHub for the actual patch merging process - that is "mailing list, public ACK, merge, push to github + sourceforge", at least today. For review, PRs should be doable. Speaking of reviewing

Re: [Openvpn-devel] automatically close PR

2016-05-02 Thread Gert Doering
Hi, On Mon, May 02, 2016 at 09:14:02AM +0200, Jens Neuhalfen wrote: > I kind of understand why openvpn does not use github pull requests to merge > (although I might debate that). > > Personally I like the github PR workflow, because it makes it > much easier to view larger changes in context. E

Re: [Openvpn-devel] automatically close PR

2016-05-02 Thread Jens Neuhalfen
Hi Ilya, > > > Hello, > > it is not very ethical to allow people to open PR in order to say later "hey, > you know, we do not accept PR” Thanks for bringing that up! > > I suggest to enable https://nopullrequests.appspot.com/ > on https://github

Re: [Openvpn-devel] automatically close PR

2016-05-02 Thread Samuli Seppänen
Hello, it is not very ethical to allow people to open PR in order to say later "hey, you know, we do not accept PR" I suggest to enable https://nopullrequests.appspot.com/ on https://github.com/openvpn/openvpn repo, it looks like a polite way of saying things. ideas? I added nopullrequests

[Openvpn-devel] automatically close PR

2016-05-02 Thread Илья Шипицин
Hello, it is not very ethical to allow people to open PR in order to say later "hey, you know, we do not accept PR" I suggest to enable https://nopullrequests.appspot.com/ on https://github.com/openvpn/openvpn repo, it looks like a polite way of saying things. ideas? Ilya Shipitsin