Re: [Openvpn-devel] The future of contrib/keychain-mcd

2017-05-06 Thread Jonathan K. Bullard
Hi. Several weeks ago "kaloprominat" submitted PR #369 [1] to Tunnelblick. It incorporates the keychain-mcd code into Tunnelblick. (I don't know if that triggered your scrutiny of keychain-mcd or if that is a coincidence.) I have not finished reviewing the PR, but it includes fixes for several pr

[Openvpn-devel] The future of contrib/keychain-mcd

2017-05-05 Thread David Sommerseth
Hi, We have had the contrib/keychain-mcd code under a more thorough code review lately. And there are several issues found during that review which really needs to be improved. Basically most of the functions handling memory management have a very ambitious coding style. The result of function