Re: [Openvpn-devel] RFC: tchar removal patch series

2025-01-08 Thread Gert Doering
Hi, On Wed, Jan 08, 2025 at 03:52:12PM -0500, Selva Nair wrote: > I think the use of tchar is outdated and I'm all for purging it. This is good :-) - would you have time to look at the commits in gerrit? gert -- "If was one thing all people took for granted, was conviction that if you feed ho

Re: [Openvpn-devel] RFC: tchar removal patch series

2025-01-08 Thread Selva Nair
Hi, I think the use of tchar is outdated and I'm all for purging it. best, Selva On Wed, Jan 8, 2025 at 8:57 AM Frank Lichtenheld wrote: > Hi. > > Today I submitted a patch series that removes all usages of > tchar.h from the OpenVPN 2 code base. You can see the full > series here: https://ge

[Openvpn-devel] RFC: tchar removal patch series

2025-01-08 Thread Frank Lichtenheld
Hi. Today I submitted a patch series that removes all usages of tchar.h from the OpenVPN 2 code base. You can see the full series here: https://gerrit.openvpn.net/q/topic:%22tchar-removal%22 This series came about when I looked into the Windows code for a potential clang-format reformat and for r