Re: [Openvpn-devel] [Patch] Support client reason from auth plugin

2018-04-25 Thread Selva Nair
Hi Thanks for the patch.This feature (and a similar support for plugins) is something very nice to have But this implementation is inadequate. The main problem is that multi->client_reason is sent back to the client only during the initial auth not during reauth (renegotiations). So this will wo

Re: [Openvpn-devel] [Patch] Support client reason from auth plugin

2018-04-20 Thread Selva Nair
Hi On Fri, Apr 20, 2018 at 4:00 AM, Gert Doering wrote: > Hi, > > On Fri, Apr 20, 2018 at 03:20:26PM +1000, Eric Thorpe wrote: >> This patch allows for a client reason to be returned from an auth plugin >> and sent to the connecting client on an auth fail. This change is >> backwards compatible w

Re: [Openvpn-devel] [Patch] Support client reason from auth plugin

2018-04-20 Thread Gert Doering
Hi, On Fri, Apr 20, 2018 at 03:20:26PM +1000, Eric Thorpe wrote: > This patch allows for a client reason to be returned from an auth plugin > and sent to the connecting client on an auth fail. This change is > backwards compatible with existing plugins and hasn't caused issues with > existing p

[Openvpn-devel] [Patch] Support client reason from auth plugin

2018-04-19 Thread Eric Thorpe
Hi All, This patch allows for a client reason to be returned from an auth plugin and sent to the connecting client on an auth fail. This change is backwards compatible with existing plugins and hasn't caused issues with existing plugins like the included pam plugin in our testing. The main pu