Re: [Openvpn-devel] [PATCHv2 1/2] Get NTLMv1 and NTLMv2 up and running

2016-12-18 Thread Steffan Karger
Hi, On 10-11-15 20:48, Gert Doering wrote: > On Fri, Oct 30, 2015 at 03:07:47PM +0100, Holger Kummert wrote: >> Am 30.10.2015 um 14:58 schrieb Steffan Karger: > [..] >>> Seems I forgot the * before the second msg_bufpos, sorry. msg_bufpos >>> itself is a pointer indeed, but *msg_bufpos is (used a

Re: [Openvpn-devel] [PATCHv2 1/2] Get NTLMv1 and NTLMv2 up and running

2015-11-10 Thread Gert Doering
Hi, On Fri, Oct 30, 2015 at 03:07:47PM +0100, Holger Kummert wrote: > Am 30.10.2015 um 14:58 schrieb Steffan Karger: [..] > > Seems I forgot the * before the second msg_bufpos, sorry. msg_bufpos > > itself is a pointer indeed, but *msg_bufpos is (used as) an offset > > into msg_buf: > > > > m

Re: [Openvpn-devel] [PATCHv2 1/2] Get NTLMv1 and NTLMv2 up and running

2015-10-30 Thread Holger Kummert
Am 30.10.2015 um 14:58 schrieb Steffan Karger: Hi Holger, On Fri, Oct 30, 2015 at 2:34 PM, Holger Kummert wrote: static void -add_security_buffer(int sb_offset, void *data, int length, unsigned char *msg_buf, int *msg_bufpos) +add_security_buffer(int sb_offset, void *data, int length, u

Re: [Openvpn-devel] [PATCHv2 1/2] Get NTLMv1 and NTLMv2 up and running

2015-10-30 Thread Steffan Karger
Hi Holger, On Fri, Oct 30, 2015 at 2:34 PM, Holger Kummert wrote: >>>static void >>> -add_security_buffer(int sb_offset, void *data, int length, unsigned char >>> *msg_buf, int *msg_bufpos) >>> +add_security_buffer(int sb_offset, void *data, int length, unsigned char >>> *msg_buf, int *msg_

Re: [Openvpn-devel] [PATCHv2 1/2] Get NTLMv1 and NTLMv2 up and running

2015-10-30 Thread Holger Kummert
Hello Steffan, Am 14.10.2015 um 00:55 schrieb Steffan Karger: Hi Holgert, Apologies for taking so long to respond. This patch came up again at the hackathon last weekend. Since we can not thoroughly test this no problem. I'm glad that someone picks this topic up. ourselves, but the patch

Re: [Openvpn-devel] [PATCHv2 1/2] Get NTLMv1 and NTLMv2 up and running

2015-10-13 Thread Steffan Karger
Hi Holgert, Apologies for taking so long to respond. This patch came up again at the hackathon last weekend. Since we can not thoroughly test this ourselves, but the patch is coming from a known source and you report successful tests, we decided that 'stare at code' should suffice. Hereby t

[Openvpn-devel] [PATCHv2 1/2] Get NTLMv1 and NTLMv2 up and running

2014-07-04 Thread Holger Kummert
* Force conversion to UTF-16 of username and domain if server requires UTF-16. * Rewrite conversion function to cleanly convert UTF-8 to UTF-16. * Fix bug in length computation in NTLMv2-code. * Architecture independent access to NTLM NegotiateFlags. Signed-off-by: Holger Kummert --- sr