Re: [Openvpn-devel] [PATCHv2] openvpn: Add missing OpenSSL includes

2018-06-29 Thread Gert Doering
Hi, On Fri, Jun 29, 2018 at 01:48:54PM +0200, Steffan Karger wrote: > Thanks for the patch. I sent similar patches half a year ago, which are > awaiting review: Thanks for pointing that out. I feel sufficiently poked. gert -- "If was one thing all people took for granted, was conviction that

Re: [Openvpn-devel] [PATCHv2] openvpn: Add missing OpenSSL includes

2018-06-29 Thread Steffan Karger
Hi, On 22-06-18 04:15, Rosen Penev wrote: > These get included when deprecated APIs are enabled. This is true on at > least version 1.0.2 and 1.1.0. > > Without deprecated APIs, OpenVPN fails to compile. > > Signed-off-by: Rosen Penev > --- > src/openvpn/ssl_openssl.c| 9 + > s

Re: [Openvpn-devel] [PATCHv2] openvpn: Add missing OpenSSL includes

2018-06-24 Thread Antonio Quartulli
Hi, for the next time, please put a space in the subject between "PATCH" and "v2", so that patchwork can happily distinguish the version from the subject-prefix. Actually git can do this for you if you specify the -vX argument (i.e. -v2) to the "git format-patch" command when creating the patch.

[Openvpn-devel] [PATCHv2] openvpn: Add missing OpenSSL includes

2018-06-21 Thread Rosen Penev
These get included when deprecated APIs are enabled. This is true on at least version 1.0.2 and 1.1.0. Without deprecated APIs, OpenVPN fails to compile. Signed-off-by: Rosen Penev --- src/openvpn/ssl_openssl.c| 9 + src/openvpn/ssl_verify_openssl.c | 1 + 2 files changed, 10 in