Re: [Openvpn-devel] [PATCH v6] convert *_inline attributes to bool

2017-05-08 Thread Antonio Quartulli
Hi, > On 25 Jan 2017, at 03:58, Steffan Karger wrote: [cut] > ACK, no more nagging from me, thanks! > > Now someone needs to go and review "[PATCH (master)] reformatting: fix > style in crypto*.{c, h}"[1], because this patch needs that one ;) > > -Steffan > > [1] > https://www.mail-archive.c

[Openvpn-devel] [PATCH v6] convert *_inline attributes to bool

2017-01-22 Thread Antonio Quartulli
Carrying around the INLINE_TAG is not really efficient, because it requires a strcmp() to be performed every time we want to understand if the data is stored inline or not. Convert all the *_inline attributes to bool to make the logic easier and checks more efficient. Signed-off-by: Antonio Quart