Re: [Openvpn-devel] [PATCH v5 2/2] Add unit tests for engine keys

2020-05-25 Thread James Bottomley
On Mon, 2020-05-25 at 14:52 +0200, Arne Schwabe wrote: > Am 25.05.20 um 08:04 schrieb Gert Doering: > > Hi, > > > > I see the granularity of your patch set as "not right": > > > > On Sun, May 24, 2020 at 01:33:22PM -0700, James Bottomley wrote: > > > Testing engines is problematic, so one of the

Re: [Openvpn-devel] [PATCH v5 2/2] Add unit tests for engine keys

2020-05-25 Thread Gert Doering
Hi, On Mon, May 25, 2020 at 07:36:11AM -0700, James Bottomley wrote: > > > configure.ac | 5 + > > > src/openvpn/crypto_openssl.c | 1 + > > > > These two hunks should go to the first patch. > > The configure.ac one adds the test Makefile ...

Re: [Openvpn-devel] [PATCH v5 2/2] Add unit tests for engine keys

2020-05-25 Thread James Bottomley
On Mon, 2020-05-25 at 08:04 +0200, Gert Doering wrote: > Hi, > > I see the granularity of your patch set as "not right": > > On Sun, May 24, 2020 at 01:33:22PM -0700, James Bottomley wrote: > > Testing engines is problematic, so one of the prerequisites built > > for > > the tests is a simple ope

Re: [Openvpn-devel] [PATCH v5 2/2] Add unit tests for engine keys

2020-05-25 Thread Arne Schwabe
Am 25.05.20 um 08:04 schrieb Gert Doering: > Hi, > > I see the granularity of your patch set as "not right": > > On Sun, May 24, 2020 at 01:33:22PM -0700, James Bottomley wrote: >> Testing engines is problematic, so one of the prerequisites built for >> the tests is a simple openssl engine that r

Re: [Openvpn-devel] [PATCH v5 2/2] Add unit tests for engine keys

2020-05-24 Thread Gert Doering
Hi, I see the granularity of your patch set as "not right": On Sun, May 24, 2020 at 01:33:22PM -0700, James Bottomley wrote: > Testing engines is problematic, so one of the prerequisites built for > the tests is a simple openssl engine that reads a non-standard PEM > guarded key. The test is sim

[Openvpn-devel] [PATCH v5 2/2] Add unit tests for engine keys

2020-05-24 Thread James Bottomley
Testing engines is problematic, so one of the prerequisites built for the tests is a simple openssl engine that reads a non-standard PEM guarded key. The test is simply can we run a client/server configuration with the usual sample key replaced by an engine key. The trivial engine prints out some