Re: [Openvpn-devel] [PATCH v5] [OSSL 3.0] Allow loading of non default providers

2021-11-11 Thread Gert Doering
Hi, On Thu, Nov 11, 2021 at 04:26:17PM -0500, Selva Nair wrote: > I'm supposing that we do not want --provider to become a M_FATAL error > in mbedTLS builds. For "generic OpenVPN" I'm not sure this makes a real difference - you know what your build uses, and if you need --provider, you know that

Re: [Openvpn-devel] [PATCH v5] [OSSL 3.0] Allow loading of non default providers

2021-11-11 Thread Selva Nair
On Thu, Nov 11, 2021 at 4:09 PM Gert Doering wrote: > > Hi, > > On Thu, Nov 11, 2021 at 08:20:51PM +0100, Arne Schwabe wrote: > > diff --git a/src/openvpn/options.c b/src/openvpn/options.c > > index b5d65d293..b1f9473dc 100644 > > --- a/src/openvpn/options.c > > +++ b/src/openvpn/options.c > > @@

Re: [Openvpn-devel] [PATCH v5] [OSSL 3.0] Allow loading of non default providers

2021-11-11 Thread Gert Doering
Hi, On Thu, Nov 11, 2021 at 08:20:51PM +0100, Arne Schwabe wrote: > diff --git a/src/openvpn/options.c b/src/openvpn/options.c > index b5d65d293..b1f9473dc 100644 > --- a/src/openvpn/options.c > +++ b/src/openvpn/options.c > @@ -8157,6 +8158,13 @@ add_option(struct options *options, >

Re: [Openvpn-devel] [PATCH v5] [OSSL 3.0] Allow loading of non default providers

2021-11-11 Thread Selva Nair
Hi, On Thu, Nov 11, 2021 at 2:21 PM Arne Schwabe wrote: > This allows OpenVPN to load non-default providers. This is mainly > useful for loading the legacy provider with --providers legacy default > > Patch v4: use spaces to seperate providers, unload providers. > Patch v5: General cleanup, rena

[Openvpn-devel] [PATCH v5] [OSSL 3.0] Allow loading of non default providers

2021-11-11 Thread Arne Schwabe
This allows OpenVPN to load non-default providers. This is mainly useful for loading the legacy provider with --providers legacy default Patch v4: use spaces to seperate providers, unload providers. Patch v5: General cleanup, rename option to --providers, add option to usage() and add an