Re: [Openvpn-devel] [PATCH v4 1/2] crypto: always reload tls-auth/crypt key contexts

2018-07-07 Thread Antonio Quartulli
Hi, On 07/07/18 20:45, Steffan Karger wrote: > Hi, [cut] >> +static void >> +free_buf_gc(struct buffer *buf, struct gc_arena *gc) >> +{ >> +if (gc) >> +{ >> +struct gc_entry **e = &gc->list; >> + >> +while (*e) >> +{ >> +/* check if this object is the

Re: [Openvpn-devel] [PATCH v4 1/2] crypto: always reload tls-auth/crypt key contexts

2018-07-07 Thread Steffan Karger
Hi, On 07-07-18 11:04, Antonio Quartulli wrote: > In preparation to having tls-auth/crypt keys per connection > block, it is important to ensure that such material is always > reloaded upon SIGUSR1, no matter if `persist-key` was specified > or not. > > This is required because when moving from o

[Openvpn-devel] [PATCH v4 1/2] crypto: always reload tls-auth/crypt key contexts

2018-07-07 Thread Antonio Quartulli
In preparation to having tls-auth/crypt keys per connection block, it is important to ensure that such material is always reloaded upon SIGUSR1, no matter if `persist-key` was specified or not. This is required because when moving from one remote to the other the key may change and thus the key co