Re: [Openvpn-devel] [PATCH v4] Improve "recursive routing" warning message

2021-03-26 Thread Gert Doering
Hi, On Fri, Mar 26, 2021 at 12:11:10PM +0100, Arne Schwabe wrote: > On Android where VPN setup is a bit different from normal setup. > Different enoguh that the recursive routing message is easily triggered > and the client always sets the allow-recursive-roouting option. I cannot > remember the e

Re: [Openvpn-devel] [PATCH v4] Improve "recursive routing" warning message

2021-03-26 Thread Arne Schwabe
Am 26.03.21 um 11:30 schrieb Antonio Quartulli: > Hi, > > On 26/03/2021 08:12, Gert Doering wrote: >> Now... if we consider a scenario where OpenVPN packets are not subject >> to be routed into the tunnel (Linux VRF, policy routing, ...) - which >> is actually something I want to see happen :-) -

Re: [Openvpn-devel] [PATCH v4] Improve "recursive routing" warning message

2021-03-26 Thread Gert Doering
Hi, On Fri, Mar 26, 2021 at 11:30:31AM +0100, Antonio Quartulli wrote: > We have two options now: > 1) extend documentation (basically what part of this patch is doing); > 2) rework this feature entirely. > > If we go with 2 I guess we don't even need 1. > > I'd go with 2, because this feature a

Re: [Openvpn-devel] [PATCH v4] Improve "recursive routing" warning message

2021-03-26 Thread Antonio Quartulli
Hi, On 26/03/2021 08:12, Gert Doering wrote: > Now... if we consider a scenario where OpenVPN packets are not subject > to be routed into the tunnel (Linux VRF, policy routing, ...) - which > is actually something I want to see happen :-) - twisting this feature > into some other direction might

Re: [Openvpn-devel] [PATCH v4] Improve "recursive routing" warning message

2021-03-26 Thread Gert Doering
Hi, On Tue, Oct 30, 2018 at 02:53:59PM +0200, Lev Stipakov wrote: > From: Lev Stipakov > > This patch provides additional information, such as > source address/port and destination address/port, to a > "recursive routing" warning message. It also mentiones > possible workaround. I still do not

Re: [Openvpn-devel] [PATCH v4] Improve "recursive routing" warning message

2021-03-26 Thread Gert Doering
Hi, On Fri, Mar 26, 2021 at 02:25:13AM +, tincanteksup wrote: > Perhaps this would be better suited as: > ./configure --enable-recursive-routing > make No. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures

Re: [Openvpn-devel] [PATCH v4] Improve "recursive routing" warning message

2021-03-25 Thread tincanteksup
On 26/03/2021 01:09, tincanteksup wrote: Hi, On 25/03/2021 23:26, Antonio Quartulli wrote: Hi, On 30/10/2018 13:53, Lev Stipakov wrote: From: Lev Stipakov + +    msg(D_LOW, "Recursive routing detected, drop packet %s. Fix your routing or consider using --allow-recursive-routing optio

Re: [Openvpn-devel] [PATCH v4] Improve "recursive routing" warning message

2021-03-25 Thread tincanteksup
Hi, On 25/03/2021 23:26, Antonio Quartulli wrote: Hi, On 30/10/2018 13:53, Lev Stipakov wrote: From: Lev Stipakov + +msg(D_LOW, "Recursive routing detected, drop packet %s. Fix your routing or consider using --allow-recursive-routing option.", BSTR(&addrs_buf)); I would add "if yo

Re: [Openvpn-devel] [PATCH v4] Improve "recursive routing" warning message

2021-03-25 Thread Antonio Quartulli
Hi, On 30/10/2018 13:53, Lev Stipakov wrote: > From: Lev Stipakov > > This patch provides additional information, such as > source address/port and destination address/port, to a > "recursive routing" warning message. It also mentiones > possible workaround. > > Trac #843 > > Signed-off-by: Le

[Openvpn-devel] [PATCH v4] Improve "recursive routing" warning message

2018-10-30 Thread Lev Stipakov
From: Lev Stipakov This patch provides additional information, such as source address/port and destination address/port, to a "recursive routing" warning message. It also mentiones possible workaround. Trac #843 Signed-off-by: Lev Stipakov --- v4: - remove unneeded format specifier for const