Re: [Openvpn-devel] [PATCH v3 4/5] Implement a function to calculate the default MTU

2022-10-11 Thread Frank Lichtenheld
On Tue, Oct 11, 2022 at 03:07:04PM +0200, Heiko Hund wrote: > On Montag, 27. Juni 2022 10:36:02 CEST Frank Lichtenheld wrote: > > As mentioned this is true for the specific options configured above. > > But you can easily also get different values out of this function by > > changing the options be

Re: [Openvpn-devel] [PATCH v3 4/5] Implement a function to calculate the default MTU

2022-10-11 Thread Heiko Hund
On Montag, 27. Juni 2022 10:36:02 CEST Frank Lichtenheld wrote: > As mentioned this is true for the specific options configured above. > But you can easily also get different values out of this function by > changing the options because frame_calculate_payload overhead does > not always return the

Re: [Openvpn-devel] [PATCH v3 4/5] Implement a function to calculate the default MTU

2022-06-27 Thread Frank Lichtenheld
NACK. See below. On Sun, Jun 26, 2022 at 01:41:49AM +0200, Arne Schwabe wrote: > diff --git a/tests/unit_tests/openvpn/test_crypto.c > b/tests/unit_tests/openvpn/test_crypto.c > index 83572b827..ca595b0a5 100644 > --- a/tests/unit_tests/openvpn/test_crypto.c > +++ b/tests/unit_tests/openvpn/test_

[Openvpn-devel] [PATCH v3 4/5] Implement a function to calculate the default MTU

2022-06-25 Thread Arne Schwabe
We could also just hardcode this value to 1420 but this approach does not add much (complicated) code and it is a bit better than to have a magic number to just be there. Signed-off-by: Arne Schwabe --- src/openvpn/mtu.c | 22 ++ src/openvpn/mtu.h