Re: [Openvpn-devel] [PATCH v3] Make compression asymmetric by default and add warnings

2020-02-17 Thread Arne Schwabe
Am 10.11.19 um 10:55 schrieb David Sommerseth: > On 09/11/2019 16:46, Steffan Karger wrote: >>> static void >>> add_option(struct options *options, >>> @@ -7322,29 +7339,78 @@ add_option(struct options *options, >>> } >>> #endif >>> #if defined(USE_COMP) >>> +else if (streq(p[0], "allo

Re: [Openvpn-devel] [PATCH v3] Make compression asymmetric by default and add warnings

2019-11-10 Thread David Sommerseth
On 09/11/2019 16:46, Steffan Karger wrote: >> static void >> add_option(struct options *options, >> @@ -7322,29 +7339,78 @@ add_option(struct options *options, >> } >> #endif >> #if defined(USE_COMP) >> +else if (streq(p[0], "allow-compression") && p[1] && !p[2]) >> +{ >> +

Re: [Openvpn-devel] [PATCH v3] Make compression asymmetric by default and add warnings

2019-11-09 Thread Steffan Karger
Hi, Feature-ack, and overall looks good. But some nits to tackle. On 24-10-2018 12:06, Arne Schwabe wrote: > This commit introduces the allow-compression option that allow > changing the new default to the previous default or to a stricter > version. > > Warning are not generated in the post opt

[Openvpn-devel] [PATCH v3] Make compression asymmetric by default and add warnings

2018-10-24 Thread Arne Schwabe
This commit introduces the allow-compression option that allow changing the new default to the previous default or to a stricter version. Warning are not generated in the post option check (options_postprocess_mutate) since these warnings should also be shown on pushed options. Patch V2: fix spel