Re: [Openvpn-devel] [PATCH v2 4/7] wintun: ring buffers based I/O

2019-11-10 Thread Lev Stipakov
Hi, As a general remark: could you try to stick to the 80 char line length > limit? > Ok. > > +#ifdef _WIN32 > > +} > > #endif > > As Simon mentioned too, this code is getting more and more hard to read. > Can we maybe do this in some cleaner way? Maybe add some helper > function(s)? > Al

Re: [Openvpn-devel] [PATCH v2 4/7] wintun: ring buffers based I/O

2019-11-09 Thread Steffan Karger
Hi, Some first-round review comments. I still need to fully grasp the event mechanism intricacies for a real in-depth review. As a general remark: could you try to stick to the 80 char line length limit? On 07-11-2019 18:45, Lev Stipakov wrote: > From: Lev Stipakov > > Implemented according to

Re: [Openvpn-devel] [PATCH v2 4/7] wintun: ring buffers based I/O

2019-11-09 Thread Simon Rozman
Hi, > -Original Message- > From: Lev Stipakov [mailto:lstipa...@gmail.com] > Sent: Thursday, November 7, 2019 6:45 PM > To: openvpn-devel@lists.sourceforge.net > Cc: Lev Stipakov > Subject: [Openvpn-devel] [PATCH v2 4/7] wintun: ring buffers based I/O > >

[Openvpn-devel] [PATCH v2 4/7] wintun: ring buffers based I/O

2019-11-07 Thread Lev Stipakov
From: Lev Stipakov Implemented according to Wintun documentation and reference client code. Wintun uses ring buffers to communicate between kernel driver and user process. Client allocates send and receive ring buffers, creates events and passes it to kernel driver under LocalSystem privileges.