Re: [Openvpn-devel] [PATCH v2 3/3] Support EC certificates with cryptoapicert

2018-02-24 Thread Selva Nair
Hi, Thanks a bunch for the review.. All good points: On Sat, Feb 24, 2018 at 11:52 AM, Steffan Karger wrote: > Hi, > > Patch looks good in general, and works as expected on my Win 10 test > box. Some minor comments below: > > On 23-02-18 19:10, selva.n...@gmail.com wrote: >> From: Selva Nair

Re: [Openvpn-devel] [PATCH v2 3/3] Support EC certificates with cryptoapicert

2018-02-24 Thread Steffan Karger
Hi, Patch looks good in general, and works as expected on my Win 10 test box. Some minor comments below: On 23-02-18 19:10, selva.n...@gmail.com wrote: > From: Selva Nair > > Requires openssl 1.1.0 or higher > > Signed-off-by: Selva Nair > --- > v3 of 2/3 changed the context of one chunk, so

[Openvpn-devel] [PATCH v2 3/3] Support EC certificates with cryptoapicert

2018-02-23 Thread selva . nair
From: Selva Nair Requires openssl 1.1.0 or higher Signed-off-by: Selva Nair --- v3 of 2/3 changed the context of one chunk, so sending a v2 rebased to current master. src/openvpn/cryptoapi.c | 199 +++- 1 file changed, 198 insertions(+), 1 deletion(