Re: [Openvpn-devel] [PATCH v2 2/2] tun.c: revise the IPv4 ifconfig flow on Windows

2020-03-15 Thread Lev Stipakov
Hi, Checked that diff between v1 and v2 is only what was mentioned in review: - ip_win32 is set to netsh only for wintun and only if existing value is dhcp_mask or adaptive - flushing arp cache is skipped for wintun Tested various combinations, works as expected. Acked-by: Lev Stipakov __

[Openvpn-devel] [PATCH v2 2/2] tun.c: revise the IPv4 ifconfig flow on Windows

2020-03-14 Thread Simon Rozman
When provisioning IP configuration, we shall not ask what kind of adapter this is. Rather, we should ask what method of provisioning we are configured to use. It is options.c's job to rule out invalid combinations. - do_ifconfig_ipv4(): unify the workflow with its IPv6 counterpart No need to di