Re: [Openvpn-devel] [PATCH v2 2/2] TLS v1.2 support for cryptoapicert -- RSA only

2018-01-21 Thread Selva Nair
Hi Steffan, Thank you for the review and the ack. On Sun, Jan 21, 2018 at 5:58 AM, Steffan Karger wrote: > Hi, > > On 20-01-18 05:52, selva.n...@gmail.com wrote: >> From: Selva Nair >> >> - If an NCRYPT handle for the private key can be obtained, use >> NCryptSignHash from the Cryptography NG

Re: [Openvpn-devel] [PATCH v2 2/2] TLS v1.2 support for cryptoapicert -- RSA only

2018-01-21 Thread Steffan Karger
Hi, On 20-01-18 05:52, selva.n...@gmail.com wrote: > From: Selva Nair > > - If an NCRYPT handle for the private key can be obtained, use > NCryptSignHash from the Cryptography NG API to sign the hash. > > This should work for all keys in the Windows certifiate stores > but may fail for ke

[Openvpn-devel] [PATCH v2 2/2] TLS v1.2 support for cryptoapicert -- RSA only

2018-01-19 Thread selva . nair
From: Selva Nair - If an NCRYPT handle for the private key can be obtained, use NCryptSignHash from the Cryptography NG API to sign the hash. This should work for all keys in the Windows certifiate stores but may fail for keys in a legacy token, for example. In such cases, we disable TLS