Re: [Openvpn-devel] [PATCH v2 2/2] Fix condition to generate session keys

2021-04-18 Thread Gert Doering
Hi, On Sun, Apr 18, 2021 at 01:48:53PM +0200, Arne Schwabe wrote: > > For master, this conflicts with commit 8fa8a17528c (compress migrate), > > which already introduces the "multi" parameter. Master only needs the > > second hunk (documentation plus CAS_SUCCEEDED check). > > I can resend it if

Re: [Openvpn-devel] [PATCH v2 2/2] Fix condition to generate session keys

2021-04-18 Thread Arne Schwabe
Am 18.04.2021 um 12:11 schrieb Gert Doering: Hi, On Sun, Mar 28, 2021 at 02:02:41PM +0200, Arne Schwabe wrote: [..] @@ -2240,7 +2240,8 @@ error: * to the TLS control channel (cleartext). */ static bool -key_method_2_write(struct buffer *buf, struct tls_session *session) +key_method_2_

Re: [Openvpn-devel] [PATCH v2 2/2] Fix condition to generate session keys

2021-04-18 Thread Gert Doering
Hi, On Sun, Apr 18, 2021 at 12:11:27PM +0200, Gert Doering wrote: > For release/2.5, this should be fine. Confirming :-) The patch 1/2 v2 (1666) needs some amount of force to go into 2.5 due to context changes, and one extra is_cas_pending(). 2/2 v2 (1667) goes right in, and succeeds Test sets

Re: [Openvpn-devel] [PATCH v2 2/2] Fix condition to generate session keys

2021-04-18 Thread Gert Doering
Hi, On Sun, Mar 28, 2021 at 02:02:41PM +0200, Arne Schwabe wrote: [..] > @@ -2240,7 +2240,8 @@ error: > * to the TLS control channel (cleartext). > */ > static bool > -key_method_2_write(struct buffer *buf, struct tls_session *session) > +key_method_2_write(struct buffer *buf, struct tls_mult

Re: [Openvpn-devel] [PATCH v2 2/2] Fix condition to generate session keys

2021-04-03 Thread Antonio Quartulli
Hi, On 28/03/2021 14:02, Arne Schwabe wrote: > When OpenVPN sees a new (SSL) connection via HARD_RESET or SOFT_RESET with > the same port/ip as an existing session, it will give it the slot of the > renegotiation session (TM_UNTRUSTED). And when the authentication > succeeds it will replace the cu

[Openvpn-devel] [PATCH v2 2/2] Fix condition to generate session keys

2021-03-28 Thread Arne Schwabe
When OpenVPN sees a new (SSL) connection via HARD_RESET or SOFT_RESET with the same port/ip as an existing session, it will give it the slot of the renegotiation session (TM_UNTRUSTED). And when the authentication succeeds it will replace the current session. In the case of a SOFT_RESET this a rene