Re: [Openvpn-devel] [PATCH v2 2/2] Clean up the pipe closing in openvpn_popen()

2014-09-09 Thread Gert Doering
Hi, On Tue, Sep 09, 2014 at 07:26:13PM +0200, David Sommerseth wrote: > From: David Sommerseth > > Do the proper closing of the pipe ends which is not being used, > also in error situations. Moved the closing of the parent side > before the waitpid(), to be consistent with the child side (as >

[Openvpn-devel] [PATCH v2 2/2] Clean up the pipe closing in openvpn_popen()

2014-09-09 Thread David Sommerseth
From: David Sommerseth Do the proper closing of the pipe ends which is not being used, also in error situations. Moved the closing of the parent side before the waitpid(), to be consistent with the child side (as early as possible). Also improved the error messages with more details. [v2 - Don