Re: [Openvpn-devel] [PATCH v2] Implement ED448 and ED25519 support in xkey_provider

2022-05-16 Thread Arne Schwabe
/* if management client cannot do digest -- we do it here */ -if (!strcmp(alg.op, "DigestSign") && !(flags & MF_EXTERNAL_KEY_DIGEST)) +if (!strcmp(alg.op, "DigestSign") && !(flags & MF_EXTERNAL_KEY_DIGEST) +&& strcmp(alg.mdname, "none") != 0) nit: Why not strcmp(alg.mdna

Re: [Openvpn-devel] [PATCH v2] Implement ED448 and ED25519 support in xkey_provider

2022-05-14 Thread Selva Nair
Hi, Thanks for the v2. I'm ready to ack this but for one issue (NULL passed to OSSL_PARAM_construct_utf8_string). On Fri, May 13, 2022 at 9:05 AM Arne Schwabe wrote: > > OpenSSL's implementation of ED448 and ED25519 has a few idiosyncrasies. > Instead of belonging to the eliptic curve type or to

[Openvpn-devel] [PATCH v2] Implement ED448 and ED25519 support in xkey_provider

2022-05-13 Thread Arne Schwabe
OpenSSL's implementation of ED448 and ED25519 has a few idiosyncrasies. Instead of belonging to the eliptic curve type or to a common Edwards curve type, ED448 and ED25519 have each their own type. Also, OpenSSL expects signatures using these curves to be done with the EVP_DigestSign API instead o