Re: [Openvpn-devel] [PATCH v2] Get rid of unused 'bool tuntap_buffer' arguments.

2023-01-31 Thread Gert Doering
Hi, On Mon, Jan 30, 2023 at 04:17:30PM +, Gert Doering wrote: > overlapped_io_init() has a "bool tuntap_buffer" argument which is only > passed onwards to alloc_buf_sock_tun(), which does nothing with it. > > Remove from both functions. > > While at it, move alloc_buf_sock_tun() from mtu.c t

Re: [Openvpn-devel] [PATCH v2] Get rid of unused 'bool tuntap_buffer' arguments.

2023-01-30 Thread Arne Schwabe
Am 30.01.23 um 17:17 schrieb Gert Doering: overlapped_io_init() has a "bool tuntap_buffer" argument which is only passed onwards to alloc_buf_sock_tun(), which does nothing with it. Remove from both functions. While at it, move alloc_buf_sock_tun() from mtu.c to win32.c and make static. It's o

[Openvpn-devel] [PATCH v2] Get rid of unused 'bool tuntap_buffer' arguments.

2023-01-30 Thread Gert Doering
overlapped_io_init() has a "bool tuntap_buffer" argument which is only passed onwards to alloc_buf_sock_tun(), which does nothing with it. Remove from both functions. While at it, move alloc_buf_sock_tun() from mtu.c to win32.c and make static. It's only ever called from win32.c / overlapped_io_