Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-22 Thread Karl O. Pinc
On 02/22/2010 03:46:33 PM, David Sommerseth wrote: > > Does that cover your concerns? Yes. It's all somewhat a matter of taste, so if you find it tasty that's good enough for me. :-) Karl Free Software: "You don't pay back, you pay forward." -- Robert A. Heinlein

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/02/10 18:16, Karl O. Pinc wrote: > On 02/22/2010 10:52:17 AM, Peter Stuge wrote: >> Karl O. Pinc wrote: >>> Someone may be relying on the behavior but, at the moment >>> or depending on present dns circumstances, does not have >>> multiple A reco

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-22 Thread Karl O. Pinc
On 02/22/2010 10:52:17 AM, Peter Stuge wrote: > Karl O. Pinc wrote: > > Someone may be relying on the behavior but, at the moment > > or depending on present dns circumstances, does not have > > multiple A records returned. In this case no warning will > > be generated. > > The flip side of that

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-22 Thread Peter Stuge
Karl O. Pinc wrote: > Someone may be relying on the behavior but, at the moment > or depending on present dns circumstances, does not have > multiple A records returned. In this case no warning will > be generated. The flip side of that coin is also valid I think. Consider independent configurat

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-22 Thread Karl O. Pinc
On 02/19/2010 05:11:38 PM, David Sommerseth wrote: > On 20/02/10 00:06, Karl O. Pinc wrote: > > On 02/19/2010 04:57:30 PM, David Sommerseth wrote: > > > > Am I wrong or does using --disable-depr-random-resolv > > not remove the random choice? > > That is correct. According to the newly agreed fea

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-22 Thread Karl O. Pinc
On 02/22/2010 01:46:53 AM, David Sommerseth wrote: The commit log > will > state that this begins the feature deprecation process, with a > warning > when this feature is used and the feature can be removed at compile > time > with --disable-depr-random-resolv. I've thought a bit more about t

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19/02/10 23:57, David Sommerseth wrote: > From: David Sommerseth > > (I'm withdrawing the first version, and suggesting this patch to be used > instead, > as this one follows the new feature deprecation process.) > > Based on a discussion on the

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/02/10 04:39, Karl O. Pinc wrote: > On 02/19/2010 05:11:38 PM, David Sommerseth wrote: >> On 20/02/10 00:06, Karl O. Pinc wrote: >>> On 02/19/2010 04:57:30 PM, David Sommerseth wrote: >>> >>> Am I wrong or does using --disable-depr-random-resolv >

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-20 Thread Gert Doering
Hi, On Fri, Feb 19, 2010 at 11:57:30PM +0100, David Sommerseth wrote: > (I'm withdrawing the first version, and suggesting this patch to be used > instead, > as this one follows the new feature deprecation process.) ACK! gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-20 Thread Karl O. Pinc
On 02/19/2010 09:39:40 PM, Karl O. Pinc wrote: > If someone who explicitly chooses a functionality > needs to get a warning about the default they > should get this warning at ./configure time -- > the time they make the choice. The only time I can think of that a warning should be delivered to

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-20 Thread Karl O. Pinc
On 02/19/2010 05:11:38 PM, David Sommerseth wrote: > On 20/02/10 00:06, Karl O. Pinc wrote: > > On 02/19/2010 04:57:30 PM, David Sommerseth wrote: > > > > Am I wrong or does using --disable-depr-random-resolv > > not remove the random choice? > > That is correct. According to the newly agreed fea

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-19 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/02/10 00:06, Karl O. Pinc wrote: > On 02/19/2010 04:57:30 PM, David Sommerseth wrote: > > Am I wrong or does using --disable-depr-random-resolv > not remove the random choice? That is correct. According to the newly agreed feature removal proc

Re: [Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-19 Thread Karl O. Pinc
On 02/19/2010 04:57:30 PM, David Sommerseth wrote: Am I wrong or does using --disable-depr-random-resolv not remove the random choice? > From: David Sommerseth > For now this feature is enabled by default, but can be disabled by > running > ./configure with --disable-depr-random-resolv. In th

[Openvpn-devel] [PATCH v2] Do not randomize resolving of IP addresses in getaddr()

2010-02-19 Thread David Sommerseth
From: David Sommerseth (I'm withdrawing the first version, and suggesting this patch to be used instead, as this one follows the new feature deprecation process.) Based on a discussion on the mailing list and in the IRC meeting Feb 18, it was decided to remove get_random() from the getaddr() fu