On 14/12/16 17:23, Steffan Karger wrote:
> On 14-12-16 16:39, David Sommerseth wrote:
>> On 14/12/16 10:09, Gert Doering wrote:
>>> Hi,
>>
>>> On Wed, Dec 14, 2016 at 10:51:18AM +0200, Lev Stipakov wrote:
+/* + * Disable async-push if plugins are disabled + */ +#if
!defined(ENABLE_PLUGIN)
On 14-12-16 16:39, David Sommerseth wrote:
> On 14/12/16 10:09, Gert Doering wrote:
>> Hi,
>
>> On Wed, Dec 14, 2016 at 10:51:18AM +0200, Lev Stipakov wrote:
>>> +/* + * Disable async-push if plugins are disabled + */ +#if
>>> !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH) +#undef
>>> ENABL
On Wed, Dec 14, 2016 at 10:39 AM, David Sommerseth wrote:
> > That one gets a NAK from me, for the reasons given.
> >
> > As long as we *have* --enable/--disable options in configure, they
> > should be validated *there* and not silently ignored.
> >
> > David's argument about "configure is for f
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 14/12/16 10:09, Gert Doering wrote:
> Hi,
>
> On Wed, Dec 14, 2016 at 10:51:18AM +0200, Lev Stipakov wrote:
>> +/* + * Disable async-push if plugins are disabled + */ +#if
>> !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH) +#undef
>> ENABLE_A
Hi,
On Wed, Dec 14, 2016 at 10:51:18AM +0200, Lev Stipakov wrote:
> +/*
> + * Disable async-push if plugins are disabled
> + */
> +#if !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH)
> +#undef ENABLE_ASYNC_PUSH
> +#endif
> +
That one gets a NAK from me, for the reasons given.
As long as we
Async push is a sub-feature of plugins.
Trac #783
Signed-off-by: Lev Stipakov
---
src/openvpn/syshead.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/openvpn/syshead.h b/src/openvpn/syshead.h
index f5008b7..c7c3259 100644
--- a/src/openvpn/syshead.h
+++ b/src/openvpn/syshead.h
