Re: [Openvpn-devel] [PATCH applied] Re: wintun: implement opening wintun device

2019-11-13 Thread Lev Stipakov
Hi, > What I do not really like is the inflation of the code with > > if (!tt->wintun) > > statements now. I think this should be refactored out into an > "open_tun_wintun()" and an "open_tun_tap_windows()" function, where > all the bits that are now inside an "if (!tt->wintun)" get thei

[Openvpn-devel] [PATCH applied] Re: wintun: implement opening wintun device

2019-11-09 Thread Gert Doering
Your patch has been applied to the master branch. Since this introduces a new library requirement, I gave it a test run on my Ubuntu 16 / MinGW linux build system. "Builds fine". Have not run the result. I have not done anything resembling proper code review. Just basic "this is only changin