Re: [Openvpn-devel] [PATCH 5/7] re-implement argv_printf_*()

2017-11-11 Thread Heiko Hund
Hi David, On Wednesday, November 9, 2016 9:41:21 PM CET David Sommerseth wrote: > In the new argv_prep_format() function: > > + if (!in_token) > +{ > + ++*count; > + if (f[0]) > +f[j++] = delim; > +} > > What is the purpose of the f[0] check? A

Re: [Openvpn-devel] [PATCH 5/7] re-implement argv_printf_*()

2016-11-09 Thread David Sommerseth
On 28/10/16 18:42, Heiko Hund wrote: > The previous implementation had the problem that it was not fully > compatible with printf() and could only detect % format directives > following a space character (0x20). > > It modifies the format string and inserts marks to separate groups > before passin

[Openvpn-devel] [PATCH 5/7] re-implement argv_printf_*()

2016-10-28 Thread Heiko Hund
The previous implementation had the problem that it was not fully compatible with printf() and could only detect % format directives following a space character (0x20). It modifies the format string and inserts marks to separate groups before passing it to the regular printf in libc. The marks are