Re: [Openvpn-devel] [PATCH 4/7] Fix a number of mingw warnings

2021-04-22 Thread Antonio Quartulli
Hi, On 22/04/2021 14:39, Arne Schwabe wrote: > >>> #ifndef _WIN32 >>> +const char *device = tt->actual_name; >> >> This variable is not used in all cases embraced by "ifndef _WIN32". >> I.e. I think it is not used when any of the following is defined: >> TARGET_OPENBSD >> TARGET_NETBSD >> TA

Re: [Openvpn-devel] [PATCH 4/7] Fix a number of mingw warnings

2021-04-22 Thread Arne Schwabe
>> #ifndef _WIN32 >> +const char *device = tt->actual_name; > > This variable is not used in all cases embraced by "ifndef _WIN32". > I.e. I think it is not used when any of the following is defined: > TARGET_OPENBSD > TARGET_NETBSD > TARGET_AIX > > Therefore this change would fix *only* t

Re: [Openvpn-devel] [PATCH 4/7] Fix a number of mingw warnings

2021-04-21 Thread Antonio Quartulli
Hi, On 21/04/2021 15:43, Arne Schwabe wrote: > Move to definition inside the ifdef where they are used to avoid > unused warnings. > > Fix a few printf related warnings when DWORD is used as paramter and > the printf format should be %lu (long unsigned int) > > Signed-off-by: Arne Schwabe > ---

[Openvpn-devel] [PATCH 4/7] Fix a number of mingw warnings

2021-04-21 Thread Arne Schwabe
Move to definition inside the ifdef where they are used to avoid unused warnings. Fix a few printf related warnings when DWORD is used as paramter and the printf format should be %lu (long unsigned int) Signed-off-by: Arne Schwabe --- src/openvpn/route.c | 4 ++-- src/openvpn/socket.c | 3 ++-