Re: [Openvpn-devel] [PATCH 4/4] make MSVC link against shell32 as well

2012-02-17 Thread Alon Bar-Lev
On Fri, Feb 17, 2012 at 11:51 AM, Heiko Hund wrote: > Alon, > > On Thursday 16 February 2012 18:37:21 Alon Bar-Lev wrote: >> On Thu, Feb 16, 2012 at 7:30 PM, Heiko Hund wrote: >> > Windows API CommandLineToArgvW(), introduced in Windows unicode path >> > commit 71bbbd76c62630c88441237d72fe5b61f0b

Re: [Openvpn-devel] [PATCH 4/4] make MSVC link against shell32 as well

2012-02-17 Thread Heiko Hund
Alon, On Thursday 16 February 2012 18:37:21 Alon Bar-Lev wrote: > On Thu, Feb 16, 2012 at 7:30 PM, Heiko Hund wrote: > > Windows API CommandLineToArgvW(), introduced in Windows unicode path > > commit 71bbbd76c62630c88441237d72fe5b61f0b45b2a, is defined therein. > > Usually this should be avoide

Re: [Openvpn-devel] [PATCH 4/4] make MSVC link against shell32 as well

2012-02-16 Thread Alon Bar-Lev
On Thu, Feb 16, 2012 at 7:30 PM, Heiko Hund wrote: > Windows API CommandLineToArgvW(), introduced in Windows unicode path > commit 71bbbd76c62630c88441237d72fe5b61f0b45b2a, is defined therein. Usually this should be avoided and get command-line from wmain().

Re: [Openvpn-devel] [PATCH 4/4] make MSVC link against shell32 as well

2012-02-16 Thread Gert Doering
Hi, On Thu, Feb 16, 2012 at 06:30:41PM +0100, Heiko Hund wrote: > Windows API CommandLineToArgvW(), introduced in Windows unicode path > commit 71bbbd76c62630c88441237d72fe5b61f0b45b2a, is defined therein. > > Signed-off-by: Heiko Hund Since you've tested it and it makes Samuli happy -> ACK :-)

[Openvpn-devel] [PATCH 4/4] make MSVC link against shell32 as well

2012-02-16 Thread Heiko Hund
Windows API CommandLineToArgvW(), introduced in Windows unicode path commit 71bbbd76c62630c88441237d72fe5b61f0b45b2a, is defined therein. Signed-off-by: Heiko Hund --- win/msvc.mak.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/win/msvc.mak.in b/win/msvc.mak.in inde