However, from my experience it is not needed, people are most capable
of manage this without creating noise.
On the contrary, displaying meaningful error messages from configure is
*never* a "noise". As Fabian pointed out - quite rightly - if make fails
due to wrong/incorrect/missing depend
On Fri, Mar 16, 2012 at 6:29 PM, Fabian Knittel
wrote:
> So it sounds as if we're actually somewhat in agreement! You don't
> want complex, automatic detection of non-standard situations and I
> agree wholeheartedly.
> But I _do_ want basic checking to achieve clear error messages at
> configurati
Hi Alon,
>> AC_CHECK_LIB([selinux], [setcon], [SELINUX_LIBS="-lselinux"])
>>
>> versus
>>
>> AC_CHECK_HEADER([selinux/selinux.h], [
>> AC_CHECK_LIB([selinux], [setcon], [SELINUX_LIBS="-lselinux"],
>> [AC_MSG_RESULT([SELinux library not found.])]
>> )], [AC_MSG_ERROR([SELinux headers
Are you referring to the configure code? I might be missing something
obvious, but
AC_CHECK_LIB([selinux], [setcon], [SELINUX_LIBS="-lselinux"])
versus
AC_CHECK_HEADER([selinux/selinux.h], [
AC_CHECK_LIB([selinux], [setcon], [SELINUX_LIBS="-lselinux"],
[AC_MSG_RESULT([SELinux libr
On Fri, Mar 16, 2012 at 5:25 PM, Fabian Knittel
wrote:
> Hi Alon,
>
> sorry for digging up the dead, but our disagreements might have
> started earlier and just went unnoticed so far ... :)
>
> 2012/3/8 Alon Bar-Lev :
>> I wrote this in the introduction of the patch set.
>>
>> There are two approa
Hi Alon,
sorry for digging up the dead, but our disagreements might have
started earlier and just went unnoticed so far ... :)
2012/3/8 Alon Bar-Lev :
> I wrote this in the introduction of the patch set.
>
> There are two approaches to detecting dependencies:
>
> 1. Detect all compile time depend
Thanks for the clarification. ACK then.
--
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc
irc freenode net: mattock
> I wrote this in the introduction of the patch set.
>
> There are two approaches to detecting dependencies:
>
> 1. Detect all compile time dependences- you detect h
I wrote this in the introduction of the patch set.
There are two approaches to detecting dependencies:
1. Detect all compile time dependences- you detect headers and
libraries, this is probably the safest way to go, but makes the code
very complex.
2. Detect library only - you assume that if lib
Looks like a cleaner implementation than the earlier one. I take it
AC_CHECK_HEADER is not anymore needed to detect selinux.h, but why exactly?
Besides that I give this one an ACK.
--
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc
irc freenode net: mattock
> Signed-off-by: Alon B
Signed-off-by: Alon Bar-Lev
---
configure.ac| 35 +++
src/openvpn/Makefile.am |1 +
src/openvpn/init.c |4 ++--
src/openvpn/options.c |6 +++---
src/openvpn/options.h |2 +-
src/openvpn/syshead.h |2 +-
6 files changed,
10 matches
Mail list logo
