Re: [Openvpn-devel] [PATCH 3/3] Make key_state->authenticated more state machine like

2020-07-08 Thread Steffan Karger
Hi, On 07-07-2020 18:20, Antonio Quartulli wrote: > On 07/07/2020 14:16, Arne Schwabe wrote: >> This order the states from unauthenticated to authenticated and also >> changes the comparison for KS_AUTH_FALSE from != to > >> >> Also remove a now obsolete comment and two obsolete ifdefs. While >> k

Re: [Openvpn-devel] [PATCH 3/3] Make key_state->authenticated more state machine like

2020-07-07 Thread Antonio Quartulli
Hi, On 07/07/2020 14:16, Arne Schwabe wrote: > This order the states from unauthenticated to authenticated and also > changes the comparison for KS_AUTH_FALSE from != to > > > Also remove a now obsolete comment and two obsolete ifdefs. While > keeping the ifdef in ssl_verify would save a few byte

[Openvpn-devel] [PATCH 3/3] Make key_state->authenticated more state machine like

2020-07-07 Thread Arne Schwabe
This order the states from unauthenticated to authenticated and also changes the comparison for KS_AUTH_FALSE from != to > Also remove a now obsolete comment and two obsolete ifdefs. While keeping the ifdef in ssl_verify would save a few bytes of code, this is too minor to justify keeping the ifde