Re: [Openvpn-devel] [PATCH 28/28] Always include ACKs for the last seen control packets

2022-05-24 Thread Frank Lichtenheld
Acked-By: Frank Lichtenheld I'm convinced that this does what it is supposed to do. Some typo fixes and one potential improvement to the UT noted below. > Arne Schwabe hat am 22.04.2022 16:29 geschrieben: > This adds an LRU cache for the last seen packets from the peer to send acks > to all rec

[Openvpn-devel] [PATCH 28/28] Always include ACKs for the last seen control packets

2022-04-22 Thread Arne Schwabe
This adds an LRU cache for the last seen packets from the peer to send acks to all recently packets. This also packets to be acknowledged even if a single P_ACK_V1 gets lost, avoiding retransmissions. The downside is that we add up to 28 byte to an P_ACK_V1 (7* packet_id) and up to 24 bytes to othe