Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file

2022-08-04 Thread Gert Doering
Hi, On Tue, Jul 05, 2022 at 11:36:37AM +0200, Antonio Quartulli wrote: > On 05/07/2022 11:32, Frank Lichtenheld wrote: > > I think this commit could use an additional sentence > > in the commit message on why exactly you remove this? > > > > Doesn't immediately make sense to me. > > To be honest

Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file

2022-07-05 Thread Lev Stipakov
We have moved dco-win uapi header to openvpn repo, so we don't have to checkout ovpn-dco-win repo to get it - this is what this commit does. But yeah, good point on having dco builds without dco. ti 5. heinäk. 2022 klo 12.36 Antonio Quartulli (a...@unstable.cc) kirjoitti: > > Hi, > > On 05/07/2022

Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file

2022-07-05 Thread Antonio Quartulli
Hi, On 05/07/2022 11:32, Frank Lichtenheld wrote: I think this commit could use an additional sentence in the commit message on why exactly you remove this? Doesn't immediately make sense to me. To be honest, I am not even sure why we have a build with DCO in the first place. There is no DCO

Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file

2022-07-05 Thread Frank Lichtenheld
I think this commit could use an additional sentence in the commit message on why exactly you remove this? Doesn't immediately make sense to me. On Fri, Jun 24, 2022 at 10:38:09AM +0200, Antonio Quartulli wrote: > Signed-off-by: Lev Stipakov > Signed-off-by: Antonio Quartulli > --- > .github/w

[Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file

2022-06-24 Thread Antonio Quartulli
Signed-off-by: Lev Stipakov Signed-off-by: Antonio Quartulli --- .github/workflows/build.yaml | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index b905c0d2..536dd9d6 100644 --- a/.github/workflows/build.yaml +