Re: [Openvpn-devel] [PATCH 2.3] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Gert Doering
Hi On Mon, Dec 07, 2015 at 10:10:55AM -0500, Selva Nair wrote: > > On Sun, Dec 06, 2015 at 07:01:47PM -0500, Selva Nair wrote: > > > Signed-off-by: Selva Nair > > > > NAK for 2.3 - what we have there works well enough. > > The reason for adding it to 2.3 was anticipating it will have to be built

Re: [Openvpn-devel] [PATCH 2.3] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Selva Nair
Hi, > On Sun, Dec 06, 2015 at 07:01:47PM -0500, Selva Nair wrote: > > Signed-off-by: Selva Nair > > NAK for 2.3 - what we have there works well enough. > The reason for adding it to 2.3 was anticipating it will have to be built for vista+ if the dns-leak patch goes in. In fact I wrote it the i

Re: [Openvpn-devel] [PATCH 2.3] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Gert Doering
Hi, On Sun, Dec 06, 2015 at 07:01:47PM -0500, Selva Nair wrote: > Signed-off-by: Selva Nair NAK for 2.3 - what we have there works well enough. Prettyfying things will only be done in master (unless the 2.3 stuff does not *work*, in which case "cleanup when fixing bugs" is fine - but it does

[Openvpn-devel] [PATCH 2.3] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Selva Nair
Signed-off-by: Selva Nair --- check_symbols_in.m4 | 43 +++ configure.ac| 17 + 2 files changed, 52 insertions(+), 8 deletions(-) create mode 100644 check_symbols_in.m4 diff --git a/check_symbols_in.m4 b/check_symbols_in.m4 new