Re: [Openvpn-devel] [PATCH 2/4] rework do_up() for correct order of DCO operations

2022-05-17 Thread Kristof Provost via Openvpn-devel
On 17 May 2022, at 15:28, Antonio Quartulli wrote: > On 16/05/2022 20:56, Kristof Provost via Openvpn-devel wrote: >> From: Kristof Provost >> >> We must create the peer before we can dco_set_peer or dco_new_key. >> On the other hand, we must first process options, because those may >> change our

Re: [Openvpn-devel] [PATCH 2/4] rework do_up() for correct order of DCO operations

2022-05-17 Thread Antonio Quartulli
Hi, On 16/05/2022 20:56, Kristof Provost via Openvpn-devel wrote: From: Kristof Provost We must create the peer before we can dco_set_peer or dco_new_key. On the other hand, we must first process options, because those may change our peer id and we should create the peer with the correct id.

[Openvpn-devel] [PATCH 2/4] rework do_up() for correct order of DCO operations

2022-05-16 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost We must create the peer before we can dco_set_peer or dco_new_key. On the other hand, we must first process options, because those may change our peer id and we should create the peer with the correct id. Split up do_deferred_options() in do_deferred_options() and finish_op

Re: [Openvpn-devel] [PATCH 2/4] rework do_up() for correct order of DCO operations

2022-05-06 Thread Kristof Provost via Openvpn-devel
On 29 Apr 2022, at 19:02, Kristof Provost wrote: From: Kristof Provost We must create the peer before we can dco_set_peer or dco_new_key. On the other hand, we must first process options, because those may change our peer id and we should create the peer with the correct id. Split up do_deferr

[Openvpn-devel] [PATCH 2/4] rework do_up() for correct order of DCO operations

2022-04-29 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost We must create the peer before we can dco_set_peer or dco_new_key. On the other hand, we must first process options, because those may change our peer id and we should create the peer with the correct id. Split up do_deferred_options() in do_deferred_options() and finish_op