Re: [Openvpn-devel] [PATCH 2/2 v4] add API for plug-ins to write to openvpn log

2012-08-06 Thread David Sommerseth
On 02/08/12 17:20, Heiko Hund wrote: > Some plugins want to add messages to the openvpn log file. The > plugin_log() and plugin_vlog() APIs provide ways for them to do so. > > OPENVPN_PLUGINv3_STRUCTVER is not incremented as the v3 plugin API > is new in 2.3 and this is merged during alpha phase.

Re: [Openvpn-devel] [PATCH 2/2 v4] add API for plug-ins to write to openvpn log

2012-08-03 Thread Heiko Hund
Hi Alon On Thursday 02 August 2012 20:20:45 Alon Bar-Lev wrote: > Thanks, although I think the extra macro is not required. It looked messy without it. That's why we have it. > Last thing I see is that you need to #include as va_list is used. It's included already. > And last style comment, I

Re: [Openvpn-devel] [PATCH 2/2 v4] add API for plug-ins to write to openvpn log

2012-08-02 Thread Alon Bar-Lev
Thanks, although I think the extra macro is not required. Last thing I see is that you need to #include as va_list is used. And last style comment, I don't think use of enum for bit fields is common, better to simply #define the constants. On Thu, Aug 2, 2012 at 6:20 PM, Heiko Hund wrote: > Som

[Openvpn-devel] [PATCH 2/2 v4] add API for plug-ins to write to openvpn log

2012-08-02 Thread Heiko Hund
Some plugins want to add messages to the openvpn log file. The plugin_log() and plugin_vlog() APIs provide ways for them to do so. OPENVPN_PLUGINv3_STRUCTVER is not incremented as the v3 plugin API is new in 2.3 and this is merged during alpha phase. Signed-off-by: Heiko Hund --- Changes since