Re: [Openvpn-devel] [PATCH 2/2 v2] Clean up get_tls_handhake_key()

2016-02-22 Thread Arne Schwabe
Am 22.02.16 um 15:24 schrieb Steffan Karger: > This function has *much* more code than required. This commit cleans up > the function: > * Merge the handling of inline and non-inline code. > * Don't double-check key.2, since must_have_n_keys() already does that >(but keep the message about

[Openvpn-devel] [PATCH 2/2 v2] Clean up get_tls_handhake_key()

2016-02-22 Thread Steffan Karger
This function has *much* more code than required. This commit cleans up the function: * Merge the handling of inline and non-inline code. * Don't double-check key.2, since must_have_n_keys() already does that (but keep the message about dropped passphrase support in 2.4). * Remove stale refe