Re: [Openvpn-devel] [PATCH 2/2] Handle PSS padding in cryptoapicert

2019-01-23 Thread Selva Nair
Hi On Wed, Jan 23, 2019 at 7:55 AM Arne Schwabe wrote: > > > Overall the code looks good. The overriding of the global RSA method is > a bit of a hack but I also do not have any better solution for this. It > might break using OpenSSL engines but that is a corner case that I would > not worry ab

Re: [Openvpn-devel] [PATCH 2/2] Handle PSS padding in cryptoapicert

2019-01-23 Thread Arne Schwabe
Am 07.12.18 um 20:17 schrieb selva.n...@gmail.com: > From: Selva Nair > > For PSS padding, CNG requires the digest to be signed > and the digest algorithm in use, which are not accessible > via the rsa_sign and rsa_priv_enc callbacks of OpenSSL. > This patch uses the EVP_KEY interface to hook to

[Openvpn-devel] [PATCH 2/2] Handle PSS padding in cryptoapicert

2018-12-07 Thread selva . nair
From: Selva Nair For PSS padding, CNG requires the digest to be signed and the digest algorithm in use, which are not accessible via the rsa_sign and rsa_priv_enc callbacks of OpenSSL. This patch uses the EVP_KEY interface to hook to evp_pkey_sign callback if OpenSSL version is > 1.1.0. To test