Re: [Openvpn-devel] [PATCH 11/25] dco: split option parsing routines

2022-06-28 Thread Arne Schwabe
Am 24.06.22 um 10:37 schrieb Antonio Quartulli: +if (!finish_options(c)) +{ +msg(D_TLS_ERRORS, "ERROR: Failed to finish option processing"); +return false; +} This error is a bit too generic for my taste. Can we make it more specific? Like "Faile

[Openvpn-devel] [PATCH 11/25] dco: split option parsing routines

2022-06-24 Thread Antonio Quartulli
DCO will try to install keys upon generating them, however, this happens when parsing pushed cipher options (due to NCP). For this reason we need to postpone parsing pushed cipher options to *after* the tunnel interface has been opened, otherwise we would have no DCO netdev object to operate on.