On 08/07/2024 23:53, Илья Шипицин wrote:
пн, 8 июл. 2024 г. в 23:47, Antonio Quartulli :
Hi,
On 08/07/2024 23:44, Илья Шипицин wrote:
+msg( M_FATAL, "Failed allocate memory saved_pid_file_name");
patchset looks great, but (!!) there should be no space after the
opening paren
пн, 8 июл. 2024 г. в 23:47, Antonio Quartulli :
>
> Hi,
>
> On 08/07/2024 23:44, Илья Шипицин wrote:
> >>> +msg( M_FATAL, "Failed allocate memory
> >>> saved_pid_file_name");
> >>
> >> patchset looks great, but (!!) there should be no space after the
> >> opening parenthesis..
> >
Hi,
On 08/07/2024 23:44, Илья Шипицин wrote:
+msg( M_FATAL, "Failed allocate memory saved_pid_file_name");
patchset looks great, but (!!) there should be no space after the
opening parenthesis..
I just followed code style already present in repo
$ grep -r 'msg( M_FATAL' .
gr
пн, 8 июл. 2024 г. в 23:13, Antonio Quartulli :
>
> Hi,
>
> On 08/07/2024 23:08, Ilia Shipitsin wrote:
> > Signed-off-by: Ilia Shipitsin
> > ---
> > src/openvpn/init.c | 4
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/src/openvpn/init.c b/src/openvpn/init.c
> > index a49e5639..
Hi,
On 08/07/2024 23:08, Ilia Shipitsin wrote:
Signed-off-by: Ilia Shipitsin
---
src/openvpn/init.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index a49e5639..59205ba6 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -4967,6 +49
Signed-off-by: Ilia Shipitsin
---
src/openvpn/init.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index a49e5639..59205ba6 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -4967,6 +4967,10 @@ write_pid_file(const char *filename, const
