Re: [Openvpn-devel] [PATCH 1/5] Fix unaligned access in auth-token

2023-01-31 Thread Frank Lichtenheld
On Mon, Jan 30, 2023 at 06:29:32PM +0100, Arne Schwabe wrote: > The undefined behaviour USAN clang checker found this. The optimiser > of clang/gcc will optimise the memcpy away in the auth_token case and output > excactly the same assembly on amd64/arm64 but it is still better to not rely > on und

[Openvpn-devel] [PATCH 1/5] Fix unaligned access in auth-token

2023-01-30 Thread Arne Schwabe
The undefined behaviour USAN clang checker found this. The optimiser of clang/gcc will optimise the memcpy away in the auth_token case and output excactly the same assembly on amd64/arm64 but it is still better to not rely on undefined behaviour. Signed-off-by: Arne Schwabe --- src/openvpn/auth_