Re: [Openvpn-devel] [PATCH 1/2] plugin: Export base64 encode and decode functions

Hi, Now that the minor "fix" for plugin header seems settled, back to the base64 export patch from David. On Fri, May 5, 2017 at 5:46 PM, David Sommerseth wrote: > This patch builds on the "Export secure_memzero() to plug-ins" patch and > adds export of openvpn_base64_encode() and openvpn_base64

Re: [Openvpn-devel] [PATCH 1/2] plugin: Export base64 encode and decode functions

Hi, On Mon, Nov 20, 2017 at 5:37 PM, Selva wrote: > Hi David, > > On Mon, Nov 20, 2017 at 3:10 PM, David Sommerseth > wrote: >> >> On 19/11/17 22:21, Selva wrote: >> > Hi David, >> > >> > On Fri, May 5, 2017 at 5:46 PM, David Sommerseth > > > wrote: >> > >> > This

Re: [Openvpn-devel] [PATCH 1/2] plugin: Export base64 encode and decode functions

Hi David, On Mon, Nov 20, 2017 at 3:10 PM, David Sommerseth wrote: > On 19/11/17 22:21, Selva wrote: > > Hi David, > > > > On Fri, May 5, 2017 at 5:46 PM, David Sommerseth > > wrote: > > > > This patch builds on the "Export secure_memzero() to plug-ins" patch > an

Re: [Openvpn-devel] [PATCH 1/2] plugin: Export base64 encode and decode functions

On 19/11/17 22:21, Selva wrote: > Hi David, > > On Fri, May 5, 2017 at 5:46 PM, David Sommerseth  > wrote: > > This patch builds on the "Export secure_memzero() to plug-ins" patch and > adds export of openvpn_base64_encode() and openvpn_base64_decode() > >

Re: [Openvpn-devel] [PATCH 1/2] plugin: Export base64 encode and decode functions

Hi David, On Fri, May 5, 2017 at 5:46 PM, David Sommerseth wrote: > This patch builds on the "Export secure_memzero() to plug-ins" patch and > adds export of openvpn_base64_encode() and openvpn_base64_decode() > > This also ships with a very simple plug-in which demonstrates how to use > the new

Re: [Openvpn-devel] [PATCH 1/2] plugin: Export base64 encode and decode functions

Hi, Thanks for the follow up with details. I also put some further thought into this overnight and totally agree with your observations. With one exception :) On Mon, May 8, 2017 at 9:56 AM, David Sommerseth wrote: > I think it is a bit too risky to actually fix the plug-in API to fix > this.

Re: [Openvpn-devel] [PATCH 1/2] plugin: Export base64 encode and decode functions

On 08/05/17 05:28, Selva Nair wrote: > Hi, > > Thanks for the patch exporting base64_encode/decode > > A quick question/comment though: quoting from your sample base64.c > > On Fri, May 5, 2017 at 5:46 PM, David Sommerseth > wrote: > > +/* Which callbacks to

Re: [Openvpn-devel] [PATCH 1/2] plugin: Export base64 encode and decode functions

Hi, Thanks for the patch exporting base64_encode/decode A quick question/comment though: quoting from your sample base64.c On Fri, May 5, 2017 at 5:46 PM, David Sommerseth wrote: > +/* Which callbacks to intercept. */ > +ret->type_mask = > +OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_

[Openvpn-devel] [PATCH 1/2] plugin: Export base64 encode and decode functions

This patch builds on the "Export secure_memzero() to plug-ins" patch and adds export of openvpn_base64_encode() and openvpn_base64_decode() This also ships with a very simple plug-in which demonstrates how to use the new exported functions. Signed-off-by: David Sommerseth --- include/openvpn-pl