Hello,
Am 04.06.2014 16:05, schrieb Holger Kummert:
Is this used - and thus tested - by you only, or is it used by UTM
customers? (This would give us confidence that it's tested by a larger
user base, and those tend to uncover issues :-) ).
Well, I thought I let it pass through the review pr
Hello Gert,
I reconsidered this point and found some lively discussions about it,
e.g. http://stackoverflow.com/questions/1674032/static-const-vs-define-in-c
The "const int" way has some advantages (as pointed out in all the
discussions I found) over the #define:
- It is type-safe
- It respects
Hello Gerd,
first of all thank you for doing a first review of the code.
Please find my comments below.
Am 02.06.2014 20:20, schrieb Gert Doering:
Hi Holger,
sorry for drag this so long. I'm not trying to stare into this, but
can't really say "this is correct" or "violating specs", lacking t
Hi Holger,
sorry for drag this so long. I'm not trying to stare into this, but
can't really say "this is correct" or "violating specs", lacking the
NTLM auth background.
Is this used - and thus tested - by you only, or is it used by UTM
customers? (This would give us confidence that it's teste
* Force conversion to UTF-16 of username and domain if server requires UTF-16.
* Rewrite conversion function to cleanly convert UTF-8 to UTF-16.
* Fix bug in length computation in NTLMv2-code.
* Architecture independent access to NTLM NegotiateFlags.
Signed-off-by: Holger Kummert
---
src/openvpn
