Re: [Openvpn-devel] [PATCH 05/12] openvpnmsica: Revise MSI custom actions interop

2020-03-23 Thread Lev Stipakov
Hi, I must say I am not super familiar with this component nor MSI in general. Stared at the code, compiled with MSVC and tested some exported functions with rundll32. This has removed lots of code, so it makes sense, assuming that all required functionality is still in place. It would be nice

[Openvpn-devel] [PATCH 05/12] openvpnmsica: Revise MSI custom actions interop

2020-03-09 Thread Simon Rozman
Sequence scripts in temporary files has been discontinued in favor of much simpler sequence strings passed to individual custom actions. Pros: no temporary files; less code Cons: the evaluation phase must make a complete plan what to perform in each deferred custom action Signed-off-by: Simon Roz